[BEAM-5195] TopPerKey support
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this operator really limited to single top value? If so, should we extend in to support configurable number of top elements in this refactoring? I would say we could do it, because it is quite trivial. We should probably add even more complex statistics operators (i.e. |
|
Yes |
VaclavPlajt
force-pushed
the
dsl-euphoria
branch
from
3faf578
to
6c49030
Compare
VaclavPlajt
force-pushed
the
vasek/support-top-per-key
branch
2 times, most recently
from
2e65bb2
to
fd69eb6
Compare
…ample and test added.
VaclavPlajt
force-pushed
the
vasek/support-top-per-key
branch
from
fd69eb6
to
d78a87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopPerKeydecomposition changed to use RBK instead of RSBK. Documentation was also updated VaclavPlajt/beam-site#2Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)