Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copied, sum, and product methods #17

Closed
wants to merge 1 commit into from

Conversation

aprilwade
Copy link

This adds the Iterator methods that FailableIterator is currently missing, resolving #15. I didn't write tests for sum or product since they just use Result's Sum and Product impls. I also didn't provide a test for copied since cloned has no tests. Naturally, if you think these need tests, I'll write them.

@sfackler
Copy link
Owner

The use of Option::copied increases the minimum supported Rust version, so it's probably best to avoid calling that method and just do the deref manually: https://circleci.com/gh/sfackler/rust-fallible-iterator/104?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants