Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement PartialEq on MessageDigest #1081

Closed
npmccallum opened this issue Mar 14, 2019 · 1 comment
Closed

implement PartialEq on MessageDigest #1081

npmccallum opened this issue Mar 14, 2019 · 1 comment

Comments

@npmccallum
Copy link
Contributor

npmccallum commented Mar 14, 2019 •
edited

It isn't currently clear how to compare two MessageDigest instances for equality. Please implement PartialEq so that developers don't try to work around the situation incorrectly.
@sfackler
Copy link
Owner

sfackler commented Mar 14, 2019 •
edited

MessageDigest implements Deref<Target = [u8]>, so you can just get the buffers out of them and compare however you like.

EDIT: Derp, I was thinking of the wrong thing.

sfackler added a commit that referenced this issue Mar 17, 2019
@sfackler
Implement Eq for MessageDigest
c3e2604 
Closes #1081
@sfackler sfackler mentioned this issue Mar 17, 2019
Merged
matkarlg pushed a commit to matkarlg/rust-openssl that referenced this issue Aug 17, 2019
@sfackler @matkarlg
Implement Eq for MessageDigest
3413fbd 
Closes sfackler#1081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npmccallum @sfackler