Add private key export to PKCS#8 in DER format #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Nov 18, 2020
|
|
||
| pub fn private_key_to_der_pkcs8(&self) -> Result<Vec<u8>, ::error::ErrorStack> { | ||
| unsafe { | ||
| let p8inf = cvt_p(ffi::EVP_PKEY2PKCS8(self.as_ptr()))?; |
There was a problem hiding this comment.
This library typically tries to map individual OpenSSL functions to individual Rust methods, so this would be split into a method that returns a Pkcs8PrivKeyInfo, and a method on that to turn that into DER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to export private keys in PKCS#8 DER format, currently the bindings only support exporting DER as a raw RSA key, or PEM in PKCS#8. At present I'm working around this by chopping off the header and trailer, then parsing the base64 back into DER, which feels a bit silly.
This pull request isn't finished; it has a memory leak still, which I'm not sure how to fix. Anyone able to help?