Add ASN.1 Integer comparison and to_owned #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skepfyr
force-pushed
the
asn1-integer-cmp
branch
from
27238f2
to
516f1b5
Compare
| } | ||
| impl PartialOrd for Asn1Integer { | ||
| fn partial_cmp(&self, other: &Asn1Integer) -> Option<Ordering> { | ||
| Some(self.cmp(other)) |
There was a problem hiding this comment.
Couldn't you just use Asn1IntegerRef::partial_cmp here as well?
There was a problem hiding this comment.
I could, but I couldn't see it making any difference and I'd already written this code.
There was a problem hiding this comment.
So the stuff looks more similar.
yeah, its more a nit.
steffen-eiden
approved these changes
Mar 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing integers is actually infallible excitingly so we can implement the proper traits for it.