Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde wrapper to serialize and deserialize Duration and SystemTime #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tailhook
Copy link

This PR supersedes #2

@tailhook tailhook mentioned this pull request May 11, 2018
@tailhook
Copy link
Author

Ping @sfackler

@tailhook
Copy link
Author

tailhook commented Aug 2, 2018

@sfackler any issues remaining?

@xoac xoac mentioned this pull request Sep 28, 2018
@xoac
Copy link

xoac commented Sep 29, 2018

For anyone who want use this PR add in [dependencies]. But I hope for version 0.2 soon :)

serde-humantime = { git = "https://github.com/tailhook/serde-humantime", branch = "serde_wrapper" }

@tyranron
Copy link

ping @sfackler

@jean-airoldie
Copy link

@tailhook This repo seems dead. Do you mind if I try to merge your branch as a feature directly into humantime?

@tailhook
Copy link
Author

Well, I prefer not to do that. Extra dependencies are always bad. And it's better a separate crate than a feature flag I think. Maybe just invent a new name for a crate? :)

@jean-airoldie
Copy link

@tailhook Sorry, I didn't realize you were the original author of the crate.

@tyranron
Copy link

@jean-airoldie nope, the badge indicates the author of pull request. Quite misleading sometimes ¯\_(ツ)_/¯

@jean-airoldie
Copy link

@tyranron I mean that humantime is tailhook's crate, so because he is filling a PR for this crate (as opposed to his) my question was spurious.

@jean-airoldie
Copy link

Ended up creating a new crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants