Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app accessible #44

Closed
hackajesse opened this issue Nov 2, 2015 · 13 comments
Closed

Make app accessible #44

hackajesse opened this issue Nov 2, 2015 · 13 comments

Comments

@hackajesse
Copy link
Member

Have James Tyack go through it. Idk his github, but he's often at hacknight. I'm sure he'd be game to go through this and/or make suggestions for things we can look out for.

@hackajesse hackajesse added this to the Basic Changes to MVP milestone Nov 2, 2015
@jszwedko
Copy link
Member

@therebelrobot were you able to talk to James?

@jeanwalshie
Copy link
Collaborator

i know we took colors/shapes into account when creating the icons (to make them distinguishable for the colorblind) but yes, we should think about this. http://www6.sfgov.org/index.aspx?page=73

@jszwedko
Copy link
Member

Are there any actions to be taken for this issue? @jeanwalshie is there someone in the government that can review?

@jszwedko jszwedko assigned jszwedko and unassigned therebelrobot Jan 17, 2016
@jeanwalshie
Copy link
Collaborator

let me look into it, thanks. stay tuned.

@jszwedko
Copy link
Member

👍 thanks!

@jeanwalshie
Copy link
Collaborator

ok, it looks like we've done the best we can with this type of a webpage. the only thing we noticed is that the icons in the legend should be properly tagged with alt text, if possible.

@jszwedko
Copy link
Member

👍 I can add that text.

jszwedko added a commit that referenced this issue Jan 21, 2016
@jszwedko
Copy link
Member

@jeanwalshie added the alt text in #123 -- let me know what you think!

@jeanwalshie
Copy link
Collaborator

@jszwedko -- i don't see the alt text on my icons in chrome. sorry, i'm sure it's something on my end. if they're there we can close this!

@jszwedko
Copy link
Member

@jeanwalshie I think you are thinking about title text (which is the text that shows up when you hover over a picture with your mouse to provide more details), but for accessibility you set a different attribute, alt text, which screen readers pick up and read in place of the picture.

If you like, I can add title text too with the same content as the alt text.

Thanks!

jszwedko added a commit that referenced this issue Jan 28, 2016
@jszwedko
Copy link
Member

Added title text in 0a87960 -- it'll need to be merged before publicly visible.

@jeanwalshie
Copy link
Collaborator

thanks @jszwedko --sorry, i didn't know the diff between alt text and title text! thanks for doing this.

@jszwedko
Copy link
Member

No worries! Closing as the pull request was merged.

kmcurry added a commit to kmcurry/adopt-a-drain that referenced this issue Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants