-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make app accessible #44
Comments
@therebelrobot were you able to talk to James? |
i know we took colors/shapes into account when creating the icons (to make them distinguishable for the colorblind) but yes, we should think about this. http://www6.sfgov.org/index.aspx?page=73 |
Are there any actions to be taken for this issue? @jeanwalshie is there someone in the government that can review? |
let me look into it, thanks. stay tuned. |
👍 thanks! |
ok, it looks like we've done the best we can with this type of a webpage. the only thing we noticed is that the icons in the legend should be properly tagged with alt text, if possible. |
👍 I can add that text. |
@jeanwalshie added the alt text in #123 -- let me know what you think! |
@jszwedko -- i don't see the alt text on my icons in chrome. sorry, i'm sure it's something on my end. if they're there we can close this! |
@jeanwalshie I think you are thinking about title text (which is the text that shows up when you hover over a picture with your mouse to provide more details), but for accessibility you set a different attribute, alt text, which screen readers pick up and read in place of the picture. If you like, I can add title text too with the same content as the alt text. Thanks! |
Added title text in 0a87960 -- it'll need to be merged before publicly visible. |
thanks @jszwedko --sorry, i didn't know the diff between alt text and title text! thanks for doing this. |
No worries! Closing as the pull request was merged. |
Promote Develop
Have James Tyack go through it. Idk his github, but he's often at hacknight. I'm sure he'd be game to go through this and/or make suggestions for things we can look out for.
The text was updated successfully, but these errors were encountered: