Skip to content

Commit

Permalink
fix: Don't flash footer at top of page while tabs are switching
Browse files Browse the repository at this point in the history
  • Loading branch information
billyc committed Mar 16, 2022
1 parent 714b29b commit 2f19ade
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/views/DashBoard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ export default class VueComponent extends Vue {
this.rows.push(cards)
}
this.$emit('layoutComplete')
}
private numberOfShownCards = 1
Expand Down
10 changes: 9 additions & 1 deletion src/views/TabbedDashboardView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
:zoomed="isZoomed"
:allConfigFiles="allConfigFiles"
@zoom="handleZoom"
@layoutComplete="handleLayoutComplete"
)

folder-browser(v-if="dashboardTabWithDelay && dashboardTabWithDelay === 'FILE__BROWSER'"
Expand All @@ -39,7 +40,7 @@

p.load-error(v-show="loadErrorMessage" @click="authorizeAfterError"): b {{ loadErrorMessage }}

.tabholder(v-show="!isZoomed" :class="{wiide}")
.tabholder(v-show="showFooter && !isZoomed" :class="{wiide}")
.tabholdercontainer(:class="{wiide}")
.project-footer(v-if="footer" v-html="footer" :class="{wiide}")

Expand Down Expand Up @@ -269,6 +270,7 @@ export default class VueComponent extends Vue {
// Force teardown the dashboard to ensure we start with a clean slate
this.activeTab = ''
this.dashboardTabWithDelay = ''
this.showFooter = false
await this.$nextTick()
this.activeTab = tab
Expand All @@ -284,6 +286,12 @@ export default class VueComponent extends Vue {
this.$emit('zoom', this.isZoomed)
}
private showFooter = false
private handleLayoutComplete() {
this.showFooter = true
}
private getFileSystem(name: string) {
const svnProject: FileSystemConfig[] = this.$store.state.svnProjects.filter(
(a: FileSystemConfig) => a.slug === name
Expand Down

0 comments on commit 2f19ade

Please sign in to comment.