Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HASSIO example revisions #116

Merged
merged 4 commits into from
Aug 2, 2020
Merged

HASSIO example revisions #116

merged 4 commits into from
Aug 2, 2020

Conversation

ktownsend-personal
Copy link
Contributor

I sync'd the HASSIO config example to match what I have done on my system.

Summary of changes:

  • a few /enabled topic fixes
  • fixed the reversed payload_on & payload_off for the freeze protection switch
  • added icons where possible
  • added delay binary sensors
  • added delay attribute on related switches
  • added active attribute on related heater switches
  • added device_type where possible
  • changed the custom battery sensor to a simulated level sensor because it's useful for battery lists in the UI, and the OK/LOW custom sensor became obsolete when I gave the mqtt binary sensor a device_type of battery (it now reports Normal/Low)
  • removed the groups because I didn't find any use for them in my situation
  • moved the pool & spa lights to switch instead of light to be more consistent with the Home Assistant convention of light being a dimmable device and non-dimmable lights being switch devices
  • added a custom service mode sensor to give the 3 states some readable labels: AUTO, SERVICE, TIMEOUT
  • added an automation to turn off the heaters when the filter pump shuts off so the heaters aren't on the next day if someone forgot to shut them off

Sync with what I ended up with on my system. Fixed some errors and added icons, device types, and delay binary sensors + delay attribute on the related switches.
The groups were unnecessary for my implementation. Also, the lights were moved to the switches to match the HASSIO convention that light devices are dimmable, but these are not dimmable and should be switches.
revised freeze protect comment
@ktownsend-personal
Copy link
Contributor Author

The link in your wiki to this file is misspelled and doesn't match the casing, so it's a broken link. I can't do a PR for the wiki, otherwise I'd fix it for you :)

@ktownsend-personal
Copy link
Contributor Author

Oh, I should mention I'm edge9421 on your forum, since my name is different here.

Copy link
Owner

@sfeakes sfeakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@sfeakes sfeakes merged commit a13d626 into sfeakes:master Aug 2, 2020
@sfeakes
Copy link
Owner

sfeakes commented Aug 2, 2020

I didn't;t realize you can't do PR on the wiki, I'll take a look. thanks for mentioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants