Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge steps in master #93

Closed
nweldev opened this issue Oct 25, 2018 · 13 comments
Closed

Merge steps in master #93

nweldev opened this issue Oct 25, 2018 · 13 comments
Assignees

Comments

@nweldev
Copy link
Contributor

nweldev commented Oct 25, 2018

As it is really difficult to maintain and use so many branches, we should only use the master.

To do so, I think the better solution would be to simply use angular-cli 7 (see #92), with a common library and several "step" apps when needed, and no root project (ie. all projects should be in the project folder).

@geromegrignon
Copy link
Contributor

geromegrignon commented Oct 25, 2018

i'll work on it.
Any changes requested about steps?

@nweldev
Copy link
Contributor Author

nweldev commented Oct 25, 2018

Not with this issue, as we don't want to impact the slides too much for now.

@nweldev
Copy link
Contributor Author

nweldev commented Oct 26, 2018

As dependencies will be updated by #95, be aware that this include to update the related Angular / rxjs / ngrx code too.

@geromegrignon
Copy link
Contributor

Sure : i'll update code when i'll add steps to master branch.

@geromegrignon
Copy link
Contributor

Next step:
Delete current App folder
Add a project folder with step-01 & step-01-solution child folders
Update angular.json to integrate step-01 & step-01-solution
Update ReadMe #96 starting with commands to launch server and projects

@geromegrignon
Copy link
Contributor

I have the following error when trying to create projects with angular cli and following the actual naming structure for steps (aka "step-01" for example) :
image

Is it ok to rename the steps by removing the dash (so "step01" and "step01-solution" for example) ?

@nweldev
Copy link
Contributor Author

nweldev commented Oct 30, 2018

You can use step1 for now, we'll think about that later.

@geromegrignon
Copy link
Contributor

Fine. I'll wait you to merge #95 to make more pull requests (readme & steps).

@nweldev
Copy link
Contributor Author

nweldev commented Oct 31, 2018

@geromegrignon #95 still have opened conversations you should address. As soon you have resolved them, I'll merge 😉

@geromegrignon
Copy link
Contributor

The only one left (not outdate or resolved) is about project architecture.
As it's # 93 purpose and the pull request opened is about #92, it sounded legit for me to resolve it in another pull request not to be confuse about pull request content.
But if you prefer to merge this pull request clearing past root content, replacing it with a first step as a working example, i can make it too.

@nweldev
Copy link
Contributor Author

nweldev commented Nov 10, 2018

@geromegrignon let me know if you need any help on this, as I'll give this school at the end of this month.

@geromegrignon
Copy link
Contributor

Great i saw it on sfeir school calendar but didn't know you were in charge for that one!

I consider Importing Material Modules that way the imports array easier to read :
image

It might be harder to catch on first sight too, let me know what you think about that!

@nweldev nweldev self-assigned this Nov 25, 2018
@nweldev
Copy link
Contributor Author

nweldev commented Nov 25, 2018

first steps handled in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants