Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi node combination LCBC #1085

Merged
merged 13 commits into from Mar 21, 2024
Merged

Conversation

vlukes
Copy link
Member

@vlukes vlukes commented Mar 5, 2024

I'm still wondering what example to use.

@rc
Copy link
Member

rc commented Mar 7, 2024

Thanks! The example looks good. Do you plan to add a test to test_lcbcs.py?

@vlukes
Copy link
Member Author

vlukes commented Mar 11, 2024

Thanks! The example looks good. Do you plan to add a test to test_lcbcs.py?

Could it be done in this way?

@rc
Copy link
Member

rc commented Mar 12, 2024

Thanks! The example looks good. Do you plan to add a test to test_lcbcs.py?

Could it be done in this way?

This would be the same as adding the example to sfepy/tests/test_declarative_examples.py, right? I was thinking more about using field.get_dofs_in_region() along the hanging node edge sides to verify the continuity.

@vlukes vlukes force-pushed the multi-node-combination-lcbc branch from 3ffdd44 to 53089c0 Compare March 21, 2024 08:05
r"""
Transformation matrix operator that define the DOFs in one (depenedent) node
as a linear combination of the DOFs in some other (independent) nodes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transformation matrix operator that defines the DOFs in one (dependent) node
as a linear combination of the DOFs in some other (independent) nodes.


.. math::
\bar u_i \sum_{j=1}^n c^{j} u_i^j\;,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\bar u_i = ...

@rc
Copy link
Member

rc commented Mar 21, 2024

I found some typos in the docstring, otherwise looks fine, thanks!

@vlukes
Copy link
Member Author

vlukes commented Mar 21, 2024

I found some typos in the docstring, otherwise looks fine, thanks!

Fixed.

@rc rc merged commit b92a35a into sfepy:master Mar 21, 2024
9 checks passed
@vlukes vlukes deleted the multi-node-combination-lcbc branch March 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants