Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exp_map_elites.cpp does not compile #97

Closed
Aneoshun opened this issue Feb 8, 2019 · 9 comments
Closed

New exp_map_elites.cpp does not compile #97

Aneoshun opened this issue Feb 8, 2019 · 9 comments

Comments

@Aneoshun
Copy link
Member

Aneoshun commented Feb 8, 2019

Hi all,
It seems that the new version of the MAP_Elites example, pused 20 days ago, does not compile. I just tried on a ubuntu 18.04, fresh sferes2 clone.

It looks like the include to Eigen is missing, some typedefs are defined several times, the gards are broken.

Does it compile with you?

@costashatz
Copy link
Collaborator

Does it compile with you?

Which file exactly? Where can we find it?

@Aneoshun
Copy link
Member Author

Aneoshun commented Feb 8, 2019

In the qd branch, in sferes2/examples/ex_map_elites.cpp (this is the default example compiled with a simple ./waf)

@costashatz
Copy link
Collaborator

It is not compiling for me...

@Aneoshun
Copy link
Member Author

@jbmouret Could you let me know what was your goal with this commit and if I can go ahead and try to debug it. Thanks.

@jbmouret
Copy link
Member

which commit are you referring to? Overall, my last commits were to try to abstract the kind of structure for nearest neighbor s(kd-tree vs partial_sort vs other), but this is clearly a work in progress and it's hard to do it alone (since I am modifying your code and I do not have any easy way to test that I did not break everything).

@Aneoshun
Copy link
Member Author

The last one on the qd branch (83cce55). It does not compile at the moment.

I know that it's hard, I want to help (especially now that I have almost finished teaching for the year).
I will think about a small qd example (like the map_elites example) and see how it can be used to test the different variants of QD.

@jbmouret
Copy link
Member

jbmouret commented Mar 29, 2019

I suppose I should not have committed this: this is clearly some work in progress (almost done, I think, but still in progress). To my defence, I was in a hospital bed at the time. Maybe I was not 100% focused...

The goal is to replace all the calls to the kdtree to a call to _storage.nearest().

I will try to finish it asap, but if you might want to revert the commit if you need a working version in this branch.

(and yes, I really need your help once it compiles because there are many subtle things in your code that I have to modify and I might break something).

@Aneoshun
Copy link
Member Author

Hoowww, sorry to read this. Francesco briefly told me about it couple of days ago, but I did not know you had to go the hospital, and no need to defend yourself.

I currently ask my students to CO the previous commit, so no need to revert it as it seems to ne almost complete, we just need to patch it.

@Aneoshun
Copy link
Member Author

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants