Main navigation helper should not draw empty navigation labels when there is namespaced models #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks CI for Ruby1.8 and Mongoid (though travisbot mysteriously says that it passes). |
|
Of course, sorry for that) Now on local all tests pass with 1.8.7 and mongoid |
mshibuya
added a commit
that referenced
this pull request
Jun 9, 2012
Main navigation helper should not draw empty navigation labels when there is namespaced models
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I need to add navigation labels for different scopes of one table. But I didn't find option which will do it for me. So I decided to use namespaced models with default scopes for right navigation labels. But when I set
navigation_labelfor parent model, previous label not disappeared.I made one spec to show my point - it will not work without changes in main navigation helper.
P.s. thank you for rails admin - it's really great! I definitely will use it again.