Fixed bug where the devise_for was being placed below the mounted engine in routes.rb #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In your README, you mention that the infinite redirect issue (#715) happens if the devise model name and the route namespace is the same ('administrators' and 'administrator'). This doesn't appear to be the bug at all. The issue is that the order is incorrect in the route. If you place it in the correct order (devise_for before mount), your example works. |
|
I have also updated the README. |
sferik
added a commit
that referenced
this pull request
Sep 26, 2012
Fixed bug where the devise_for was being placed below the mounted engine in routes.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I perform a
rails g rails_admin:installand go through the process, it places thedevise_for :adminsroute below themount RailsAdmin::Engine => '/admin', :as => 'rails_admin'. This will cause a redirect loop. The fix for this is to place thedevise_forabove themountin the routes.rb.I have modified the order of the generator script to resolve the issue.