Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery UI Timepicker to v0.3.2 #1584

Merged
merged 1 commit into from
Apr 2, 2013
Merged

Upgrade jQuery UI Timepicker to v0.3.2 #1584

merged 1 commit into from
Apr 2, 2013

Conversation

jgrevich
Copy link
Contributor

The date picker elements were creating errors due to the use of the depreciated jQuery.browser method. This fixes the problem and works with jQuery 1.9. All tests pass but one (rspec ./spec/integration/config/list/rails_admin_config_list_spec.rb:399 # RailsAdmin Config DSL List Section default sorting has reverse direction by default) which is the same as master branch.

The date picker elements were creating errors due to the use of the
depreciated jQuery.browser method. This fixes the problem and works
with jQuery 1.9.
@coveralls
Copy link

Coverage decreased (-0.15%) when pulling 68ed303 on jgrevich:update_jquery_ui_timepicker into 8533e5a on sferik:master.

View Details

@jgrevich
Copy link
Contributor Author

This problem will occur in Rails 3 apps that require 'jquery-rails' (which is default in all new rails apps) without restricting to version below 2.2 (e.g. '~> 2.1.0'). After 2.2 jquery-rails uses jQuery 1.9 which causes the above error.

@jgrevich
Copy link
Contributor Author

It's odd that the travis build is failing for mongoid but not AR. Why would updating a javascript datepicker have any effect on the "RailsAdmin Config DSL Edit Section embedded model works" test?

  1) RailsAdmin Config DSL Edit Section embedded model works
     Failure/Error: expect(@record.embeds.length).to eq(1)

       expected: 1
            got: 2

       (compared using ==)

bbenezech added a commit that referenced this pull request Apr 2, 2013
@bbenezech bbenezech merged commit ec547e8 into railsadminteam:master Apr 2, 2013
@bbenezech
Copy link
Collaborator

Don' t mind the error, it's not related.

Thanks for the patch

@jgrevich jgrevich deleted the update_jquery_ui_timepicker branch April 27, 2013 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants