Fix: novalidate attribute merging #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalpo
force-pushed
the
fix/browser_validations
branch
from
700f7ca
to
21660c1
Compare
dalpo
changed the title
|
Please merge this one, I need to disable this feature Browser validations break the save feature on persisted objets with image attachments
|
mshibuya
added a commit
that referenced
this pull request
Aug 10, 2015
Fix: novalidate attribute merging
|
Thanks for the fix! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
novalidateactually is overrided byhtmlrails_admin_form_for options in the rails_admin views.With this PR the novalidate attribute will be merged into the html options correctly.