Load models from eager_load, not autoload_paths #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me. I currently have to explicitly exclude classes in lib. Annoying! |
|
@impurist ActiveRecord |
|
@mshibuya どう思いますか？ |
|
So eager_load_paths is poorly named |
|
Agreed, but it would be better to have a spec that will fail without this change. |
If something is in `autoload_paths`, it doesn't mean it can or should *always* be loaded. Rails explicitly makes this distinction with `eager_load`. E.g. if I'm developing a Rails engine, I might want to add `lib` to autoload paths (to ease the development of the engine), but that doesn't mean I want to eagerly load ruby files in `lib/generators/templates`! Resolves railsadminteam#2770
|
@mshibuya Done |
|
Nice, can be merged if the rubocop offense is fixed. |
|
@mshibuya Sorry, didn't notice it. Now fixed! |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If something is in
autoload_paths, it doesn't mean it can or should always be loaded. Rails explicitly makes this distinction witheager_load.E.g. if I'm developing a Rails engine, I might want to add
libto autoload paths (to ease the development of the engine), but that doesn't mean I want to eagerly load ruby files inlib/generators/templates!Resolves #2770