Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load models from eager_load, not autoload_paths #2771

Merged
merged 2 commits into from
Mar 20, 2017
Merged

Load models from eager_load, not autoload_paths #2771

merged 2 commits into from
Mar 20, 2017

Commits on Mar 18, 2017

  1. Load models from eager_load, not autoload_paths 

    If something is in `autoload_paths`, it doesn't mean it can or should *always* be loaded. Rails explicitly makes this distinction with `eager_load`.

E.g. if I'm developing a Rails engine, I might want to add `lib` to autoload paths (to ease the development of the engine), but that doesn't mean I want to eagerly load ruby files in `lib/generators/templates`!

Resolves railsadminteam#2770
    @glebm
    glebm committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    1bc00d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2017

  1. Fix rubocop

    @glebm
    glebm authored Mar 20, 2017
    Configuration menu
    Copy the full SHA
    dd3e4fc View commit details
    Browse the repository at this point in the history