PaperTrail extension updates #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaperTrail compatibility notes that `v12.x` is the only version supported by Ruby 2.5.
[Starting in `v10.1.0`](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md#deprecated-1), PaperTrail updated the configuration for defining a custom version class for a model. In RailsAdmin, this impacts the `history#index` view - as the PaperTrail adapter will use the fallback `@version_class` and fail to render the appropriate versions for a configured model.
mshibuya
reviewed
Aug 12, 2021
The custom version class is typically set in an initializer, kept with `PaperTrailTestWithCustomAssociation` here for visibility.
Aligning with the version used in the existing `versions` table migration to allow for this migration / related tests to be used in the 2.x stable branch (that supports older Rails versions)
|
Awesome, thanks! |
mshibuya
added a commit
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following decf428, this updates the PaperTrail adapter to