Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for RuboCop bug until new RuboCop release. #341

Closed
wants to merge 2 commits into from

Conversation

smalleel
Copy link

@smalleel smalleel commented Sep 14, 2016

Temporary fix for issue #340 mentioned by @groddeck. This should be rolled back after the new version of RuboCop is released.

@groddeck
Copy link
Contributor

Looks like 3 additional issues to address. From the Travis output:

Offenses:
Gemfile:17:18: C: Use the new Ruby 1.9 hash syntax.
  gem 'rubocop', :github => 'bbatsov/rubocop', :ref => '90bc9d4' 
                 ^^^^^^^^^^
Gemfile:17:48: C: Use the new Ruby 1.9 hash syntax.
  gem 'rubocop', :github => 'bbatsov/rubocop', :ref => '90bc9d4' 
                                               ^^^^^^^
lib/t/rcfile.rb:20:7: C: Use a guard clause instead of wrapping the code inside a conditional expression.
      if possibilities.size == 1
      ^^
33 files inspected, 3 offenses detected
RuboCop failed!

Copy link
Owner

@sferik sferik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, this pull request introduces two new Rubocop issues:

Gemfile:17:18: C: Use the new Ruby 1.9 hash syntax.

Copy link
Author

@smalleel smalleel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@smalleel
Copy link
Author

smalleel commented Sep 18, 2016

Whoops, my mistake there! @sferik the change you posted for review looks good to me! Apologies for being a little new to the github workflow-- let me know if there's anything else I need to do to have your review commit merged into this branch.

@smalleel
Copy link
Author

It looks like the new Rubocop release is out: https://github.com/bbatsov/rubocop/releases

I'll close this pull request since it shouldn't be needed any longer. :)

@smalleel smalleel closed this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants