Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing support for video upload and STATUS commands #796

Closed
wants to merge 8 commits into from
Closed

Fixing support for video upload and STATUS commands #796

wants to merge 8 commits into from

Conversation

himberjack
Copy link

No description provided.

@himberjack himberjack mentioned this pull request Aug 17, 2016
Closed
@tibbon
Copy link

tibbon commented Aug 17, 2016

Have you had any luck uploading the media itself?

@himberjack
Copy link
Author

Yes. An MP4 file... Afterwhich I made /status/update request

@sferik
Copy link
Owner

sferik commented Aug 17, 2016

Can you please add tests for this new method?

@narlei
Copy link

narlei commented Sep 14, 2016 •
edited

@sferik Why only supports MP4 video file? There any way to send other formats?

@tibbon
Copy link

tibbon commented Sep 14, 2016

I believe that's a Twitter limitation. There are very specific guidelines
around what they allow.

https://dev.twitter.com/rest/media/uploading-media#videorecs

On Wed, Sep 14, 2016 at 3:06 PM, Narlei Moreira notifications@github.com
wrote:

Why only supports MP4 video file? There any way to send other formats?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#796 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFDwK2x_YUAyVPe6OVQQaBcq8witztpks5qqEW7gaJpZM4JmcGh
.

@himberjack
Copy link
Author

Added the test. Please merge

@jonmast jonmast mentioned this pull request Dec 19, 2016
Closed
@sobrinho
Copy link

Hey guys, any blockers on this pull request?

@sobrinho sobrinho mentioned this pull request Apr 20, 2017
Closed
@sobrinho
Copy link

I believe #824 has a complete implementation as sometimes the video is not processed immediately and the update is denied (the #824 make it wait for the video process).

@sferik sferik force-pushed the master branch 6 times, most recently from eb3650b to dde79c4 Compare February 12, 2020 17:28
@sferik sferik closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@himberjack @tibbon @sferik @narlei @sobrinho