-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse unitPreferencesTest.txt preparing to run data-driven tests #26
Conversation
This diff will be smaller once #25 has been merged - please consider reviewing and merging that first? |
dbfb6d0
to
cd7b0cc
Compare
I wasn't sure how to make the diff be against the updated units-staging branch (to pick up PR #25), so I went ahead and rebased it on that branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just some small things
Exploring good ways to handle github code reviews: this time I'm not clicking on "resolved" - I'm leaving that to you. I think they're all resolved though, and I might as well have clicked them myself. |
Yep, sounds good, I'll click resolve to verify that they are resolved. |
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#20 Commit: 9f65f41 ICU-20568 Read unitsTest.txt, prepare to run unit tests. PR: sffc#25 Commit: 4be0a2b No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#26 Commit: 9e021f9 Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#34 Commit: 12a5289 Improve test output: no more fprintfs. PR: sffc#33 Commit: 44e9afb Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#31 Commit: ca34233 Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#41 Commit: be7f699 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
Read unitsTest.txt, prepare to run unit tests. PR: sffc#20 Commit: 9f65f41 No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#25 Commit: 4be0a2b Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#26 Commit: 9e021f9 Improve test output: no more fprintfs. PR: sffc#34 Commit: 12a5289 Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#33 Commit: 44e9afb Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#31 Commit: ca34233 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master PR: sffc#41 Commit: be7f699
Read unitsTest.txt, prepare to run unit tests. PR: sffc#20 Commit: 9f65f41 No-op/cosmetic: reformat with clang-format ident:4 line-length:105. PR: sffc#25 Commit: 4be0a2b Parse unitPreferencesTest.txt preparing to run data-driven tests PR: sffc#26 Commit: 9e021f9 Improve test output: no more fprintfs. PR: sffc#34 Commit: 12a5289 Update to latest CLDR test files: b7a23f3f41 CLDR-13587. PR: sffc#33 Commit: 44e9afb Add unitsdata.cpp, getConversionRatesInfo, and unit tests. PR: sffc#31 Commit: ca34233 Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master PR: sffc#41 Commit: be7f699
No description provided.