Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testConversions: test convertibility of unitsTest.txt test cases. #39

Merged
merged 6 commits into from Apr 29, 2020
Merged

testConversions: test convertibility of unitsTest.txt test cases. #39

merged 6 commits into from Apr 29, 2020

Conversation

hugovdm
Copy link
Collaborator

@hugovdm hugovdm commented Apr 29, 2020 •
edited

This adds code to test convertibility of unitsTest.txt cases.

Once merged with #21, uncommenting the commented code helps test unit conversions. (Most succeed, there are a few failures.)

@hugovdm hugovdm requested review from sffc and younies April 29, 2020 15:08
@hugovdm hugovdm requested a review from sffc April 29, 2020 16:32
sffc
sffc reviewed Apr 29, 2020
View reviewed changes
Copy link
Owner

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to add assertNotEquals for int32_t to intltest.

@hugovdm hugovdm requested a review from sffc April 29, 2020 19:56
@hugovdm
Copy link
Collaborator Author

hugovdm commented Apr 29, 2020

Awaiting review of the assertNotEquals addition.

@sffc sffc merged commit 3202693 into sffc:units-staging Apr 29, 2020
younies added a commit that referenced this pull request May 7, 2020
@younies
Merge pull request #39 from younies/tryingdouble_staging
05b0b5c 
add a TODO to load the constants\' values from the units data
@hugovdm hugovdm deleted the unitsTestTxt branch May 11, 2020 21:09
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 15, 2020
@hugovdm
PR: sffc#39
00701dc 
Commit: 3202693

testConversions: test convertibility of unitsTest.txt test cases.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: sffc#39
054db04 
Commit: 3202693

testConversions: test convertibility of unitsTest.txt test cases.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: sffc#39
e4f3d76 
Commit: 3202693

testConversions: test convertibility of unitsTest.txt test cases.
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
PR: sffc#39
1984b69 
Commit: 3202693

testConversions: test convertibility of unitsTest.txt test cases.
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
testConversions: test convertibility of unitsTest.txt test cases.
3e652a8 
PR: sffc#39
Commit: 3202693
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
testConversions: test convertibility of unitsTest.txt test cases.
9195555 
PR: sffc#39
Commit: 3202693
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 15, 2020
@hugovdm
testConversions: test convertibility of unitsTest.txt test cases.
e358a6c 
PR: sffc#39
Commit: 3202693
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 28, 2020
@hugovdm
testConversions: test convertibility of unitsTest.txt test cases.
cc2597a 
PR: sffc#39
Commit: 3202693
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 1, 2020
@hugovdm
ICU-20568 testConversions: test convertibility of unitsTest.txt test …
7fdc5e3 
…cases.

PR: sffc#39
Commit: 3202693
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 9, 2020
@hugovdm
ICU-20568 testConversions: test convertibility of unitsTest.txt test …
a048fd8 
…cases.

PR: sffc#39
Commit: 3202693
hugovdm added a commit to unicode-org/icu that referenced this pull request Sep 10, 2020
@hugovdm
ICU-20568 testConversions: test convertibility of unitsTest.txt test …
4d07e3b 
…cases.

PR: sffc#39
Commit: 3202693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@younies younies younies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hugovdm @sffc @younies