handle kooky variable names input to crosstab and tabyl

closes #87

R/crosstab.R

@@ -66,6 +66,8 @@ crosstab.default <- function(vec1, vec2, percent = "none", show_na = TRUE, ...){
     var_name <- names(vec1)
   }
 
+  # an odd variable name can be deparsed into a vector of length >1, rare but breaks function, see issue #87
+  if(length(var_name) > 1){ var_name <- paste(var_name, collapse = "") }
 
   if(!show_na){
     dat <- dat[!is.na(dat[[1]]) & !is.na(dat[[2]]), ]
@@ -91,7 +93,7 @@ crosstab.default <- function(vec1, vec2, percent = "none", show_na = TRUE, ...){
 
   # calculate percentages, if specified
   if(percent != "none"){result <- ns_to_percents(result, denom = percent)}
-  
+
   result %>%
     stats::setNames(., c(var_name, names(.)[-1])) %>%
     data.frame(., check.names = FALSE)

R/tabyl.R

@@ -45,6 +45,9 @@ tabyl.default <- function(vec, sort = FALSE, show_na = TRUE, ...) {
   } else {
     var_name <- names(vec)
   }
+
+  # an odd variable name can be deparsed into a vector of length >1, rare but throws warning, see issue #87
+  if(length(var_name) > 1){ var_name <- paste(var_name, collapse = "") }
 
   # calculate initial counts table
   # convert vector to a 1 col data.frame

tests/testthat/test-crosstab.R

@@ -110,4 +110,19 @@ test_that("bad input variable name is preserved", {
   k <- mtcars %>% mutate(`bad name` = cyl)
   expect_equal(crosstab(k$`bad name`, k$gear) %>% names %>% .[[1]],
                "k$`bad name`")
-})
+})
+
+test_that("bizarre combination of %>%, quotes, and spaces in names is handled", {
+  dat <- data.frame(
+    `The candidate(s) applied directly to my school` = c("a", "b", "a", "b"),
+    x = 1:4,
+    check.names = FALSE,
+    stringsAsFactors = FALSE
+  )
+
+expect_equal(
+  crosstab(dat$`The candidate(s) applied directly to my school` %>% gsub("hi", "there", .), dat$x) %>%
+    names() %>% .[1],
+  "dat$`The candidate(s) applied directly to my school` %>% gsub(\"hi\",     \"there\", .)"
+)
+})

tests/testthat/test-tabyl.R

@@ -117,4 +117,18 @@ test_that("input variable names 'percent' and 'n' are handled", {
                           n_n = c(18, 7),
                           percent = c(18/25, 7/25))
   )
-})
+})
+
+test_that("bizarre combination of %>%, quotes, and spaces in names is handled", {
+  dat <- data.frame(
+    `The candidate(s) applied directly to my school` = c("a", "b", "a", "b"),
+    check.names = FALSE,
+    stringsAsFactors = FALSE
+  )
+
+  expect_equal(
+    tabyl(dat$`The candidate(s) applied directly to my school` %>% gsub("hi", "there", .)) %>%
+      names() %>% .[1],
+    "dat$`The candidate(s) applied directly to my school` %>% gsub(\"hi\",     \"there\", .)"
+  )
+})