Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further reading references to 'tz' argument of excel_numeric_to_date #233

Closed
sfirke opened this issue Aug 20, 2018 · 2 comments
Closed
Milestone

Comments

@sfirke
Copy link
Owner

sfirke commented Aug 20, 2018

Related to #232, I think we should provide a reference link in the documentation for the tz argument that would allow users to read more about valid timezones and see a list of them. I found my way to https://data.iana.org/time-zones/tz-link.html but would like something simpler. A list of common timezones on a website might be more useful to the typical user than shell commands to download a tarball.

Maybe two links, the one I have above for further / more advanced reading and a simpler one with list of common timezones?

@billdenney
Copy link
Collaborator

I have a similar response here that unless we want to handle the complexity of timezones internally (which I think is better left to other functions and packages), we would be better off linking to the functions that handle the timezones for us.

To get the list, we can suggest base::OlsonNames(), and to get the current time zone, we can suggest base::Sys.timezone(). That would be my preference.

@sfirke
Copy link
Owner Author

sfirke commented Mar 15, 2019

I like your fix: add to the documentation of the tz argument that they can see a list of timezones with base::OlsonNames() and their current timezone with base::Sys.timezone().

@sfirke sfirke added this to the v1.2 milestone Mar 15, 2019
billdenney added a commit to billdenney/janitor that referenced this issue Mar 15, 2019
sfirke pushed a commit that referenced this issue Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants