Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify text for adorn_total() #263

Closed
StephieLaPugh opened this issue Jan 26, 2019 · 3 comments
Closed

Specify text for adorn_total() #263

StephieLaPugh opened this issue Jan 26, 2019 · 3 comments

Comments

@StephieLaPugh
Copy link

Hi there,

I am loving this package, and I figured out the workaround for converting columns to characters (formatting with scales functions also works) before adding adorn_totals(), and that works great. (Though I'd still vote for being able to specify columns to sum in the adorn_totals() arguments directly.)

I would also like to be able to enter my own text instead of "Total". "Total" is great as the default, but it would just be nice to be able to use custom text because clients want what they want, don't they? ;-)

Thanks!

@sfirke
Copy link
Owner

sfirke commented Feb 14, 2019

thanks @StephieLaPugh for suggesting this and @daniel-barnett for implementing! This also makes the package slightly friendlier to users working in a language other than English.

@daniel-barnett
Copy link
Contributor

Great news @sfirke!

@StephieLaPugh
Copy link
Author

Sweet! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants