Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean_names respects separators (or lack) between number and letter #177

Merged
merged 2 commits into from Feb 9, 2018

Conversation

sfirke
Copy link
Owner

@sfirke sfirke commented Feb 8, 2018

closes #153. Now email2 stays email2 instead of becoming email_2, but email 2 still becomes email_2.

Also test case alias consistency and improve function documentation
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #177   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         601    601           
=====================================
  Hits          601    601
Impacted Files Coverage Δ
R/clean_names.R 100% <100%> (ø) ⬆️

@sfirke sfirke merged commit 3bade07 into master Feb 9, 2018
@sfirke sfirke deleted the clean_names_trailing_numbers branch February 9, 2018 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean_names() appends underscore before trailing number
1 participant