Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown support #5

Merged
merged 6 commits into from Sep 22, 2022
Merged

Markdown support #5

merged 6 commits into from Sep 22, 2022

Conversation

rudychung
Copy link
Contributor

Fixes #4

I added:

  • support for reading .md files, both from an input directory and input file
  • reading bold markdown indicators
  • reading italic markdown indicators

I attempted to change as little of the original source code as possible. I used regex to search for the markdown indicators and index slicing to remove the indicators that were replaced by HTML tags. There is some code repetition that needs to be resolved on the function that I added to convert markdown indicators to the appropriate HTML tags.

Copy link
Owner

@sfrunza13 sfrunza13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding MD support, could you also add support for multiple MD elements in the same new line?

@sfrunza13 sfrunza13 merged commit 4c100a0 into sfrunza13:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown support
2 participants