Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve using typeRoots #1

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Solve using typeRoots #1

merged 1 commit into from
Mar 12, 2021

Conversation

puckey
Copy link
Contributor

@puckey puckey commented Mar 11, 2021

Here is another solution to the missing types problem:

  • set zapatos's outDir to ../types
  • the zapatos directory in /types already contains an index.d.ts which will import the generated schema.d.ts file.
  • add "typeRoots": ["./types"] to base-tsconfig.json in root
  • have other ts-config.json of packages extend from base-tsconfig.json

@freshtonic
Copy link

That's a decent workaround, thanks @puckey

Copy link
Owner

@sfsr12 sfsr12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much cleaner. I knew there would be a good solution just couldn’t think of it.

Thanks for the PR.

@sfsr12 sfsr12 merged commit ec4b48b into sfsr12:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants