Fix bessel zeros #70
Merged
Fix bessel zeros #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #57 (comment) The result seems to be more or less identical to the one obtained with sphbesselh_zeros() in terms of stability -- the obtained values for z, p differ quite a lot. One advantage of sphhankel_laplace() is that it will not lead to Inf or Nan, but only to large numerical errors in the reproduced sound field for orders >85. Maybe it would be a good idea to try to calculate z directly via an formula without using the zeros() function.
The poles are always zero and are now directly set by zeros()
The function has now a hardcoded method switch to choose between both methods for calculatinh the zeros. We should do some testing which is the better method and use that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of Bessel zeros for high orders with the Multiprecisson Toolbox was wrong, see #57.
This pull request removes the usage of the Multiprecission Toolbox and tests if there are other working approaches available for high orders.