Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake version 2.8 does not recognize Python 3.4 #12

Closed
organman91 opened this issue Oct 27, 2014 · 4 comments
Closed

CMake version 2.8 does not recognize Python 3.4 #12

organman91 opened this issue Oct 27, 2014 · 4 comments

Comments

@organman91
Copy link

Adding

set(Python_ADDITIONAL_VERSIONS 3.4)

to the beginning of cpp/CMakeLists.txt corrects this issue.

Alternatively, CMake 3 could be a (more clearly specified) requirement.

@snoek09
Copy link
Contributor

snoek09 commented Oct 27, 2014

Or add version 3.4 to the list in (Ubuntu 14.04):

/usr/share/cmake-2.8/Modules/FindPythonLibs.cmake (line 41)
/usr/share/cmake-2.8/Modules/FindPythonInterp.cmake (line 36)

@mic-e
Copy link
Member

mic-e commented Oct 27, 2014

If cmake 3.0 is available in all distros that also have the other dependencies (such as recent versions of gcc and/or g++, libopusfile, ...), there's no reason not to just bump the required cmake version to that version instead of applying hacks. Any feedback on that (I guess Debian stable is out anyway, but what about the various versions of Ubuntu, Fedora, ...)?

@organman91
Copy link
Author

On Ubuntu 14.04 the latest available version is 2.8.12 (unless there's a suitable backport).

@mic-e
Copy link
Member

mic-e commented Oct 27, 2014

set(Python_ADDITIONAL_VERSIONS 3.4) it is, then. Though I believe it belongs into python.cmake rather than the cpp.cmake :P

@mic-e mic-e closed this as completed in 8656a7b Oct 27, 2014
schets added a commit to schets/openage that referenced this issue Nov 12, 2014
thanks to organman91 for reporting

fixes SFTtech#12
inakoll added a commit to inakoll/openage that referenced this issue Nov 24, 2014
thanks to organman91 for reporting

fixes SFTtech#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants