Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building placement sound #59

Closed
TheJJ opened this issue Oct 30, 2014 · 3 comments · Fixed by #108
Closed

Building placement sound #59

TheJJ opened this issue Oct 30, 2014 · 3 comments · Fixed by #108
Labels
area: assets Involved with assets (images, sounds, ...) bug Behaving differently as it should behave lang: c++ Done in C++ code
Milestone

Comments

@TheJJ
Copy link
Member

TheJJ commented Oct 30, 2014

The sound playback when planting buildings does not work. The selection of the creation sound happens in the temporary game loading routines, which seems to fail to associate the correct sound ids.

@TheJJ TheJJ added bug Behaving differently as it should behave lang: c++ Done in C++ code area: assets Involved with assets (images, sounds, ...) labels Oct 30, 2014
@TheJJ TheJJ added this to the v3.0 milestone Oct 30, 2014
@franciscod
Copy link
Contributor

After adding these lines I only get 291 and 337 as sound_creation0...

https://github.com/franciscod/openage/commit/24160c01f91c406fdf3bdd9815a617b0821634b5

% make run | grep sndcre
MSG sndcre 291 -1
MSG sndcre 291 -1
MSG sndcre 337 -1
MSG sndcre 291 -1
MSG sndcre 291 -1
MSG sndcre 337 -1
MSG sndcre 337 -1

Can anyone reproduce this?

(Might it be because my game is the Spanish version?)

@Mandelbug
Copy link

Same result with your code @franciscod
Some buildings play sound when placed.

[m building[10]: TREBU
[m    slp id/name: 1244 TREBU_FN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 291 -1
[m building[55]: PTREB
[m    slp id/name: 2279 PTREB_WN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 291 -1
[m building[63]: PMANG
[m    slp id/name: 2279 PTREB_WN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 337 -1
[m building[98]: HBNB
[m    slp id/name: 1244 TREBU_FN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 291 -1
[m building[99]: HGOS
[m    slp id/name: 1244 TREBU_FN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 291 -1
[m building[113]: HGOSP
[m    slp id/name: 2279 PTREB_WN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 337 -1
[m building[114]: HBNBP
[m    slp id/name: 2279 PTREB_WN
[m    building has foundation size 0.50 x 0.50 = 1x1
[m sndcre 337 -1

@franciscod
Copy link
Contributor

#108 tries to fix both placement and destruction sounds

@TheJJ TheJJ closed this as completed in #108 Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: assets Involved with assets (images, sounds, ...) bug Behaving differently as it should behave lang: c++ Done in C++ code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants