Infinite Postgres Bug #573 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJackson2020
force-pushed
the
infinite_postgres_bug
branch
from
2a9db84
to
41c7896
Compare
AndrewJackson2020
force-pushed
the
infinite_postgres_bug
branch
from
2a3db1f
to
853bec7
Compare
|
Thanks for the PR @AndrewJackson2020 , it looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a bug with postgres implementation. In postgres many numeric/date data types can have infinite or negative infinite values. Currently when one of these values is selected in connector-x it results in a runtime panic error. This PR fixes this issue for 3 data type (datetime, date, and real).
Resolves Issue 572