Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Supports structured construction of database connection. #613

Merged
merged 10 commits into from
Apr 22, 2024
Merged

feat: Supports structured construction of database connection. #613

merged 10 commits into from
Apr 22, 2024

Conversation

zen-xu
Copy link
Contributor

@zen-xu zen-xu commented Apr 19, 2024 •
edited
Loading

This PR can provide some type hints to help build a DB connection.

image image image

@zen-xu zen-xu changed the title feat: Supports structured construction of database connection string. feat: Supports structured construction of database connection. Apr 19, 2024
@wangxiaoying
Copy link
Contributor

Thanks @zen-xu for the PR! This feature could be very helpful. : )

One minor comment is that can you rename the Connection class to ConnectionStr or ConnectionURL ? Otherwise one may think it as a real database connection like the ones supported pandas instead of the url for it. Thank you!

@zen-xu
rename Connection -> ConnectionUrl
349d742 
Signed-off-by: ZhengYu, Xu <zen-xu@outlook.com>
@zen-xu
Copy link
Contributor Author

zen-xu commented Apr 22, 2024

Hi @wangxiaoying, ready to merge

@wangxiaoying wangxiaoying merged commit a9e73f2 into sfu-db:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zen-xu @wangxiaoying