Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TD3 hyperparameters really improve the performance? #21

Closed
zuoxingdong opened this issue Jan 27, 2020 · 3 comments
Closed

New TD3 hyperparameters really improve the performance? #21

zuoxingdong opened this issue Jan 27, 2020 · 3 comments

Comments

@zuoxingdong
Copy link

Could you confirm that the new hyperparameters for TD3 (i.e. network size from [400, 300] to [256, 256], batch size from 100 to 256, learning rate from 1e-3 to 3e-4) really improve the performance?

In my experiment, it does not demonstrate a consistent improvement.
image

@sfujim
Copy link
Owner

sfujim commented Jan 27, 2020

The new hyper-parameters are necessary for TD3 to learn on Humanoid, but there shouldn't be any big changes on the other environments.

@zuoxingdong
Copy link
Author

zuoxingdong commented Jan 27, 2020

@sfujim thanks for your reply!

Did you mean that for other environments (e.g. HalfCheetah, Hopper etc.), we should use the original set of hyperparameters and use the new one only for Humanoid?

@sfujim
Copy link
Owner

sfujim commented Jan 28, 2020

If you're only interested in maximizing performance then probably. The original hyper-parameters were also not well-optimized as we originally wanted to stay close to DDPG for a fair comparison. If you are comparing to other methods which don't use per-environment hyper-parameters then in my opinion using only one set of hyper-parameters is more fair but it's up to you & your use-case. Best of luck!

@sfujim sfujim closed this as completed Jan 28, 2020
minghongx added a commit to TACPSLab/snn-ctrl that referenced this issue Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants