Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored projects are very out of date #5

Closed
1 of 3 tasks
dvzrv opened this issue Feb 25, 2023 · 5 comments · Fixed by sfztools/sfizz#1145
Closed
1 of 3 tasks

Vendored projects are very out of date #5

dvzrv opened this issue Feb 25, 2023 · 5 comments · Fixed by sfztools/sfizz#1145

Comments

@dvzrv
Copy link

dvzrv commented Feb 25, 2023

Hi! I package sfizz for Arch Linux.

We usually try to build using our system provided libraries as bundling is problematic. This is also the case for header only things such as lv2 and vst3sdk.
Unfortunately sfizz carries very old versions of both by now and it would be great if they would be kept in sync with upstream releases.

From a distribution perspective it would be great if:

  • the project would detect system-wide provided libraries with higher priority than the bundled ones.
  • Update the bundled dependencies.
  • Additionally, it would be great to have a bot automatically bump the versions of the dependencies, so that they can be automatically integration tested by CI.
@dvzrv
Copy link
Author

dvzrv commented Feb 25, 2023

One outcome of this is, that sfizz can not be built with current vst3sdk: steinbergmedia/vst3_public_sdk#41

archlinux-github referenced this issue in archlinux/svntogit-community Feb 25, 2023
Remove unnecessary quotes and curly braces.
Stop devendoring of vst3sdk, as sfizz is broken with newer versions:
https://github.com/sfztools/sfizz/issues/1143
steinbergmedia/vst3_public_sdk#41
https://bugs.archlinux.org/task/76046
Add patch to fix lv2 linting with lv2lint: https://github.com/sfztools/sfizz/issues/1071
Streamline cmake calls to adhere to packaging guidelines.

git-svn-id: file:///srv/repos/svn-community/svn@1403984 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github referenced this issue in archlinux/svntogit-community Feb 25, 2023
Remove unnecessary quotes and curly braces.
Stop devendoring of vst3sdk, as sfizz is broken with newer versions:
https://github.com/sfztools/sfizz/issues/1143
steinbergmedia/vst3_public_sdk#41
https://bugs.archlinux.org/task/76046
Add patch to fix lv2 linting with lv2lint: https://github.com/sfztools/sfizz/issues/1071
Streamline cmake calls to adhere to packaging guidelines.

git-svn-id: file:///srv/repos/svn-community/svn@1403984 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@redtide redtide reopened this Mar 29, 2023
@paulfd
Copy link
Member

paulfd commented Apr 1, 2023

The reason I pinned vstgui at the time was that it lead to deeply corrupted output on Linux. Since 4.11 was still new, I figured maybe the implementation did not see so much Linux exposure yet. Then life caught on. I'll see if it's resolved as soon as I can.

@redtide
Copy link
Member

redtide commented Apr 7, 2023

Also Abseil seems a bit problematic to update on sfizz side, see sfztools/sfizz#1154. Though it builds fine when using C++17 (VST3 requires it). Anyway you can already build using all the required system libraries with new additional CMake options added in sfztools/sfizz#1145. I tested also with the current Arch vst3sdk version and the latest; some random crashes when removing and re-adding the VST3 plugin in Carla, plus there are some patches to apply because some other unresolved issues.

@redtide redtide transferred this issue from sfztools/sfizz May 8, 2023
@redtide
Copy link
Member

redtide commented May 13, 2023

  • Additionally, it would be great to have a bot automatically bump the versions of the dependencies, so that they can be automatically integration tested by CI.

I hope CPM will be the right tool to handle it, but this will take a while.

@redtide
Copy link
Member

redtide commented May 22, 2023

Closing: the last missing update was merged in #1169.

A last thing:

the project would detect system-wide provided libraries with higher priority than the bundled ones.

I'm not sure about this with all the Linux/BSD distro and other platforms. I hope it's not a problem to let this as a manual task for users and packagers; possibly this might change in future, but any dependency could be problematic at any time for any reason, otherwise bundled libraries might not be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants