Support updated crossfading during note playback #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The right channel should be blank at this point of the process so you only need to apply the envelope to the left channel
|
Hey! Thanks alot, that's exactly what I had in mind so yeah you got it right :) I just corrected a couple things, so if you agree with the 2 commits I can merge. Did you try it? Does it sound as expected? |
|
@paulfd I didn't get the results that I expected, but I think it was because of the mistakes that you corrected. Let's go ahead and merge it, and I'll let you know how it goes. |
|
Ok let's see! |
iv-m
pushed a commit
to iv-m/sfizz
that referenced
this pull request
Oct 17, 2023
Update vst3sdk 3.7.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulfd I took a crack at this, I'm not sure if I got it right though.