Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary work for aftertouch handling #630

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Preliminary work for aftertouch handling #630

merged 3 commits into from
Feb 12, 2021

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Feb 5, 2021 •
edited

  • Add the aftertouch modulation source
  • Dispatch aftertouch events and track the aftertouch status in the midi state
  • Parse cutoff_chanaft
  • Convert aftertouch messages to an extended CC message

TODO:

  • Test !
  • Investigate the compile error with atomic_queue... strange that it never happened before, seems like a red herring.
  • Verify if e.g. ARIA allows extended CCs to be used e.g. for locc/hicc opcodes, or is it just for modulations.

@paulfd paulfd mentioned this pull request Feb 5, 2021
Closed
@paulfd paulfd linked an issue Feb 5, 2021 that may be closed by this pull request
[FR] Add support for channel pressure (monophonic aftertouch) #7
Closed
@paulfd paulfd removed a link to an issue Feb 5, 2021
[FR] Add support for channel pressure (monophonic aftertouch) #7
Closed
@paulfd paulfd mentioned this pull request Feb 6, 2021
Closed
10 tasks
@paulfd paulfd requested a review from jpcima February 8, 2021 14:31
@paulfd
Preliminary work for aftertouch handling
6deb3d3 
- Add the aftertouch modulation source
- Dispatch aftertouch events and track the aftertouch status in the midi state
- Parse cutoff_chanaft
- Convert aftertouch messages to an extended CC message
@paulfd
Use the normal CC codepath, to also trigger notes
d1d659b
@paulfd
Add tests for extended cc triggers on aftertouch
6b4f535
@paulfd paulfd merged commit ce1dda5 into sfztools:develop Feb 12, 2021
@paulfd paulfd deleted the aftertouch branch January 21, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcima jpcima Awaiting requested review from jpcima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@paulfd