Midnam

[jpcima]

This adds the ability for LV2 to export MIDNAM information to Ardour.

The controllers should show in the automation menu with their adequate labels.

It's maybe worth noting that if no controls have labels, nothing will be shown in the menu, so maybe we want to do something about it.

Adds following external code

• Ardour LV2 extensions (ISC) ­— LV2 midnam interfaces
• Pugixml (MIT) — structured XML writer library

[paulfd]

I'm not the author of this file 🙂
On a side note I think there's no real need to track file copyright since we have a version control system, so we can just maintain the LICENSE.md file and author's list globally. I realize now that I updated the C++ library like this but kept my name in the lv2 plugin, I think this is unnecessary.

[jpcima]

It's not about the authorship, but copyright assignment.
When a project is assigned to one single person, it facilitates such things as update the license in the future, if there is ever need.

As I recall, GNU for instance requires copyrigth assignment from their contributors.

[paulfd]

Ok I see your point, but I'm not super comfortable asking for copyright assignments. Since we're discussing code style and contibution guidelines in general, I propose we move the discussion on this there since it's not really the heart of the PR.

[paulfd]

I need to try it out! Does this work with Ardour 5 or 6? I put minor comments in there, I can correct this myself if you want.

Reading the Ardour extension header, I am wondering if we could use the "Bankpatch" along the MIDNAM to indicate the currently activated keyswitch?

[jpcima]

Based on a quick check, it works in 6 only.

There is one limitation to expect now, as noted in the OP, only CC which are labelled are listed in the menu.

I will edit later, or you can do so immediately yourself if you prefer.

Reading the Ardour extension header, I am wondering if we could use the "Bankpatch" along the MIDNAM to indicate the currently activated keyswitch?

Possibly, as I have only filled one subset of Midnam related to the controllers.

[paulfd]

I added an issue for the unlabelled CCs in #80 since it's going to be easier soon. For the bankpatch as there's no handling of the keyswitch names for now it's less relevant but it could be an interesting addition. I'll be able to change this tonight at the earliest, but otherwise I'm good to merge!