Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate IP address in SAN #56

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Truncate IP address in SAN #56

merged 2 commits into from
Mar 9, 2022

Conversation

sgallagher
Copy link
Owner

In OpenSSL 1.1, this was done automatically when addind a SAN extension,
but in OpenSSL 3.0 it is rejected as an invalid input.

Signed-off-by: Stephen Gallagher sgallagh@redhat.com

Attn: @mvollmer

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sgallagher-sscg-56
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
In OpenSSL 1.1, this was done automatically when addind a SAN extension,
but in OpenSSL 3.0 it is rejected as an invalid input.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Copy link

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with this from the point of view of a guy that just wants sscg to work. :-) I can't say anything about the correctness.

@mvollmer
Copy link

mvollmer commented Mar 9, 2022

So is the mask used for anything now?

@sgallagher
Copy link
Owner Author

So is the mask used for anything now?

Yes, it's still required for the namingConstraints extension, but it's not required (or permitted) for the subjectAlternativeName extension.

@sgallagher sgallagher merged commit 2e98893 into main Mar 9, 2022
@sgallagher sgallagher deleted the truncate_san branch March 9, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants