Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on empty array destructuring #2

Closed
turadg opened this issue Sep 14, 2018 · 3 comments
Closed

Errors on empty array destructuring #2

turadg opened this issue Sep 14, 2018 · 3 comments
Labels
wontfix This will not be worked on

Comments

@turadg
Copy link

turadg commented Sep 14, 2018

For example,

}).then(([, session]) => {
@sgilroy
Copy link
Owner

sgilroy commented Sep 16, 2018

@turadg Can you please provide a more complete example?

I tested with the following, and there was no error from the code mod:

function arrayDestructuring() {
  return b().then(([, destructuredArrayElement]) => {
    return destructuredArrayElement.d;
  });
}

Result:

async function arrayDestructuring() {
  const [, destructuredArrayElement] = await b();
  return destructuredArrayElement.d;
}

@turadg
Copy link
Author

turadg commented Sep 17, 2018

Sorry, can't find the example anymore. But I did file a couple more detailed bug report.

FWIW, here's the success rate on my repo,

136 errors
2324 unmodified
2 skipped
6 ok

@sgilroy sgilroy added the wontfix This will not be worked on label Sep 23, 2018
@sgilroy
Copy link
Owner

sgilroy commented Sep 23, 2018

@turadg Please provide details if you can reproduce.

@sgilroy sgilroy closed this as completed Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants