Code reformatting #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgladstone
approved these changes
Sep 9, 2019
I would probably have 2 more reformatting PRs, and then PRs for minor features. For example, Chabadsuite had implemented a setting for 'earliest bat mitzvah' and I see that you recently opened a feature for that. We also have a unit test for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sarah, this PR is only a code-reformatting PR. It is to help me send PRs for other changes that had been done for @Chabadsuite. (the code format is the one recommended by CiviCRM)
If you are OK with the code format, I would also send a PR for utils/HebrewCalendar.php, and then PRs for things like php unit tests, and some minor fixes/tweaks, but I will PR them separately to make it easier to review.