Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

[#433] [FEATURE] Amélioration de l'ergonomie de la gestion d'erreur du formulaire d'inscription (US-496). #433

Merged
merged 4 commits into from
Jun 8, 2017

Conversation

jbuget
Copy link
Contributor

@jbuget jbuget commented May 31, 2017

  • modification du message d'erreur en cas de non-cochage des CGU (pour qu'il tienne sur une ligne)
  • suppression de l'effet "disparaissant" du message de notification en titre du formulaire
  • renommage (et passage de <div/> à <p/>) du message de notification ("temporaryMessage" -> "notificationMessage"
  • suppression du message d'erreur général en cas d'erreur (les erreurs par champs suffisent)
  • suppression des classes CSS inutiles
  • ajout de tests

@jbuget jbuget changed the title [#] [FEATURE] Améliorer l'ergonomie de la gestion d'erreur du formulaire d'inscription (US-496). [#433] [FEATURE] Améliorer l'ergonomie de la gestion d'erreur du formulaire d'inscription (US-496). May 31, 2017
@jbuget jbuget changed the title [#433] [FEATURE] Améliorer l'ergonomie de la gestion d'erreur du formulaire d'inscription (US-496). [#433] [FEATURE] Amélioration de l'ergonomie de la gestion d'erreur du formulaire d'inscription (US-496). May 31, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-28.006%) to 66.533% when pulling 9ef080d on 496-remove-useless-error-message-signup-form into 1db16c0 on dev.

@jbuget
Copy link
Contributor Author

jbuget commented May 31, 2017

I've deployed this PR to http://496-remove-useless-error-message-signup-form.pix.beta.gouv.fr. Please check it out

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.439% when pulling a2309a6 on 496-remove-useless-error-message-signup-form into 1db16c0 on dev.

@jbuget
Copy link
Contributor Author

jbuget commented Jun 1, 2017

I've deployed this PR to http://496-remove-useless-error-message-signup-form.pix.beta.gouv.fr. Please check it out

@Akhilian Akhilian force-pushed the 496-remove-useless-error-message-signup-form branch from a2309a6 to f4a2ded Compare June 8, 2017 08:43
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.492% when pulling f4a2ded on 496-remove-useless-error-message-signup-form into c3513ab on dev.

@jbuget
Copy link
Contributor Author

jbuget commented Jun 8, 2017

I've deployed this PR to http://496-remove-useless-error-message-signup-form.pix.beta.gouv.fr. Please check it out

@Akhilian Akhilian merged commit 53ae5a7 into dev Jun 8, 2017
@Akhilian Akhilian deleted the 496-remove-useless-error-message-signup-form branch June 8, 2017 09:06
@jbuget jbuget added this to the v1.12.0 milestone Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants