-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features from lasybear/sph-sgminer_x11mod #217
Conversation
Can i get a list of required fixes in my commits? As i understand first thing: return WATCHDOG_SICK_TIME to 120. |
What should i fix next? |
It looks much better now. |
Internet crash, for example. Or user configured just one/two pools for mining and it's offline. |
And the point is just to save power? |
Yes. Actually, i don't care about electricity, because i pay 0.04$ per kW/h. But someone pays more, a lot of more. |
I don't think this is the right approach to this. We can simply disable all devices. Perhaps it's also necessary to shutdown threads, but I don't think so. Is this even an actual problem, do the devices actually work on anything if there is no new work from pool? They don't just idle? |
No, they don't work. Tried to unplug internet connection: clocks dropped, gpu usage: 0. |
so then there is no need for that change? |
I'm using sgminer version with this fix. I will try to run version without. |
Same behavior. Maybe depends from driver, looks like we don't need it. Should i remove it or you will remove it in merger process? |
I'll take care of it in the evening. Normally you would do a rebase yeah, and force push that. Similarly you could rebase and update existing commits if needed, instead of adding new commits. |
WATCHDOG_SICK_TIME increase reverted Hardcode in get_work_blockdiff removed
Sorry, did some experiments with my git and as result i lost all your comments in commits. I'm so sorry. |
Yeah no worries, this is normal if you rebase and force push... |
I will merge all except GPU idle thing. Also next time please base your stuff on v5_0 branch instead of master. |
Merged (see https://github.com/sgminer-dev/sgminer/commits/v5_0) |
Extend time to sick state
Gpu sets idle, if all pools dead
Total uptime length in first string
show-coindiff option
P.S. Sorry for second pull request, first time selected wrong branch