Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add voume controls #117

Merged
merged 16 commits into from
Jan 15, 2024
Merged

feature/add voume controls #117

merged 16 commits into from
Jan 15, 2024

Conversation

sgobotta
Copy link
Owner


name: Pull Request
about: Feature that adds volume controls
title: 'Improve video controls with volume management'
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Add a player image preview in the rooms list liveview
  • Expose local server to the LAN
  • Add player an volume assets
  • Add a fullscreen asset
  • Remove ids from svgs
  • Update back and next buttons
  • Add a volume control
  • Implement client-side volume handlers
  • Handle mute/unmute events
  • Handle fullscreen events
  • Increase drag delay for scrollability

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 5134cda243e6adc255136cdee1efa32995ffefe3-PR-117

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 50.556%

Totals Coverage Status
Change from base Build eecd030780b41ed2a92df7bc88fb46ef263e9abd: -1.2%
Covered Lines: 637
Relevant Lines: 1260

💛 - Coveralls

@sgobotta sgobotta merged commit 81b4173 into dev Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants