Fix Travis CI tests failing

[ayan-usgs]

Travis CI is erroring. Investigate and fix if necessary.

[ocefpaf]

Our travis link is pointing to https://travis-ci.org/sgrid/pysgrid and that is showing @jay-hennen latest work. (The latest merge to master seems OK. We might want to look into changing the badge link to point to the master merges, not sure how yet...)

BTW @jay-hennen working from master is not recommended. It is preferred to create a branch, work from there, and send the PR.

Take a look at https://guides.github.com/introduction/flow/ and https://guides.github.com/activities/hello-world/. They are both nice introductions to the GitHub Workflow we use.

[ocefpaf]

OK I see a segfault here. Something changed on Travis-CI 😒 I will take a look.

[ayan-usgs]

It's beguiling. I can't seem to reliably reproduce the segmentation fault....

Guess it's time to do some Googling.

[ayan-usgs]

What's exceedingly bizarre is that the Travis CI tests will run without a segmentation fault when running against by fork, but will fail on PR requests to master from that fork. It's the same code and the Travis CI settings are ostensibly the same.

[ocefpaf]

Segfaults are always fun...

[ChrisBarker-NOAA]

this may have been the segfaulting with netcdf that seems to have been cleaned up with the test restructuring -- let's close it.