Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest #81

Merged
merged 1 commit into from
Feb 9, 2016
Merged

pytest #81

merged 1 commit into from
Feb 9, 2016

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Feb 8, 2016

This doe not switch to py.test entirely, there are still a few tweaks needed to get rid of nose. Let's see if this helps diagnose #80.

@ocefpaf ocefpaf force-pushed the py.test branch 4 times, most recently from d0d364a to 2e0a345 Compare February 8, 2016 19:30
@ocefpaf ocefpaf force-pushed the py.test branch 2 times, most recently from 2125e9b to ed348a2 Compare February 8, 2016 19:41
@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 8, 2016

@ayan-usgs it seems that netCDF4-python 1.2.2 introduced some change that is causing the segfault on Travis-CI.

Downgrading solves the problem, but what is weird is that I can run the tests locally with 1.2.2 without any problem. (It is one of those hard to find bug.)

For now let's just use 1.2.1 and while for 1.2.3 and check if the problem is still there.

PS: I will investigate this more and report it upstream. I have a suspicion that it might be affecting some of my other projects and maybe this build.

@@ -1,2 +1,2 @@
netCDF4 >=1.2.0
netCDF4 >=1.2.0,<1.2.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line did not work with early conda, but it is fine now!

Ping @kwilcox. You asked me recently about standardizing conda and pip requirements. I guess that conda can take pip syntax now as long as the package name is the same. (Both pip and conda are case insensitive BTW.)

@ocefpaf
Copy link
Member Author

ocefpaf commented Feb 8, 2016

Just to provide another data point. My project gridgeo was also being affect by this:
pyoceans/gridgeo#18

@ayan-usgs
Copy link
Contributor

@ocefpaf,

Thanks for figuring that out! Would have taken me awhile.

ayan-usgs added a commit that referenced this pull request Feb 9, 2016
@ayan-usgs ayan-usgs merged commit 348b263 into sgrid:master Feb 9, 2016
@ocefpaf ocefpaf deleted the py.test branch February 9, 2016 14:22
@ocefpaf ocefpaf mentioned this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants