Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 idea #45

Closed
chrisblossom opened this issue Jan 7, 2018 · 5 comments
Closed

2.0 idea #45

chrisblossom opened this issue Jan 7, 2018 · 5 comments
Labels

Comments

@chrisblossom
Copy link

It might be a good idea to release v2.0 in plain javascript. I think it would help to make the code base easier for the majority to contribute to. I know I've personally been put away because I don't know CoffeeScript's syntax at all.

If you are against it, or just plain prefer CoffeeScript, I completely understand! Just a thought.

decaffeinate/decaffeinate can take care of the heavy lifting.

Thanks for this great library!

@SGrondin
Copy link
Owner

SGrondin commented Jan 8, 2018

I agree with you that it'd be more welcoming and it has been a long term goal since the beginning of this project.

CoffeeScript was selected out of necessity, not out of love. When this project started in 2013, ES5 was just not up to the task and the code would have been a few hundred very ugly lines of code instead of 31 beautiful ones. I strongly believe that bugs hide better in ugly, long, convoluted code than beautiful, terse and straightforward code.

Over the years, JavaScript has absorbed 95% of CoffeeScript's good features and if I were to start Bottleneck now, I'd do it in modern JavaScript.

Version 2 is 99% ready to go, I just need to collect more feedback, fix a bug and do a final pass at the Readme.

Version 2 involved completely separating the internal engine from the rest of the module and making that engine asynchronous to the module itself so that I could then make a 2nd pluggable engine that uses Redis. The changes were so huge, I didn't want to lose all of the stability that modifying working and tested software provides me. I don't really believe in rewrites, I believe in slowly reshaping code until it becomes what I want it to become. Each small step of the way gets fully tested and debugged and the end result is always superior to a rewrite. For all these reasons, V2 is still in CS.

But now that all that is done, I'd be able to slowly start converting the code to JS, one method, one file at a time. There's still a couple of things in CS that are missing from JS, so the end result will be longer, uglier code, but I think that making it more approachable to beginners is probably worth it. But, at the same time, does it really matter considering that making any change to this library requires a deep understanding of JavaScript's complicated scoping rules, concurrency and distributed systems? The bar is already so high. Maybe, I'm not sure.

@chrisblossom
Copy link
Author

@SGrondin, thanks for the very thought out reply. If you would like any help with the process after 2.0 is released, I'd be happy to do what I can.

@SGrondin
Copy link
Owner

I'll let you know!

@tjenkinson
Copy link
Contributor

Congrats on v2!

@SGrondin
Copy link
Owner

Thanks @tjenkinson ! Lemme know what you think of it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants