Update flash helper to use Foundation 6's callout #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dsandstrom
commented
Mar 3, 2016
dsandstrom
commented
- Change to callout class
- Update close link to use a button tag and add data attributes
- Update tests because of helper changes
added 3 commits
March 3, 2016 14:51
* Change to callout class * Update close link to use a button tag and add data attributes * Update tests because of helper changes
|
Added foundation-6 branch until we want to merge it into master. |
|
link #121 |
Don't include gem version changes. This should changed in a different PR.
It makes it so the callout added by flash messages is easier to select with CSS as opposed to callouts already on the page.
|
See #126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.