Change input hint to help text #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change to callout class * Update close link to use a button tag and add data attributes * Update tests because of helper changes
It makes it so the callout added by flash messages is easier to select with CSS as opposed to callouts already on the page.
The text under the input has a different class so I changed the option key and css class. http://foundation.zurb.com/sites/docs/forms.html#help-text Fixes sgruhier#145
|
@dsandstrom his needs a change in the readme, which still refers to 'hints' |
|
This has been fixed in #147 |
|
OK |
dgmstuart
force-pushed
the
foundation-6
branch
from
169134b
to
eacc83d
Compare
|
@dsandstrom would you mind rebasing on top of foundation-6 |
|
Closed in favor of #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text under the input has a different class so I changed the option
key and css class.
http://foundation.zurb.com/sites/docs/forms.html#help-text
Fixes #145